-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[강원대 Android_주민철] 2주차 과제 2단계 #65
Open
joominchul
wants to merge
31
commits into
kakao-tech-campus-2nd-step2:joominchul
Choose a base branch
from
joominchul:feat-joominchul-step2
base: joominchul
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[강원대 Android_주민철] 2주차 과제 2단계 #65
joominchul
wants to merge
31
commits into
kakao-tech-campus-2nd-step2:joominchul
from
joominchul:feat-joominchul-step2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
장소 추가 함수
매개 변수로 받은 Place가 존재하는지 확인
추가할 장소가 존재하지 않으면 추가
이름을 검색해서, 검색어를 포함하는 이름을 가진 장소 데이터를 리턴하는 함수
데이터베이스에 데이터가 있는지 확인하는 함수
검색어를 입력하면 검색 결과 목록이 표시되고, 목록은 세로 스크롤이 됨
장소 확인을 like 대신 = 으로 변경
result를 리턴하도록 변경
검색 결과 목록에서 하나의 항목을 선택하면, 검색어 저장 목록에 추가가 되고 가로 스크롤이 됨.
저장된 검색어는 앱을 재실행하여도 유지된다.
mkSpace
requested changes
Jul 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 민철님 예비군도 다녀오시고 학습할 시간이 충분치 않으셨을 텐데도 잘 작성해주셨네요. 이번주도 수고 많으셨습니다. 리뷰 남겨드리니 의견 부탁드려요!
MVVM 아키텍처를 이제 학습해서 바로 적용하기는 쉽지 않죠. 천천히 학습하시고 변경해보시는걸 추천드립니다.
사실 데이터의 흐름이 DB -> View로 흐르게끔 작성하는게 베스트이긴 한데 현재 단계에서 이를 구현하기에는 쉽지 않은 일이죠. 우선 이번 단계에서는 어떤 부분이 문제가 있고 힘든지 힘껏 만끽하셨으면 좋겠습니다.
addTextChangedListener 대신 doOnTextChanged를 사용하였다.
UISetting에서 setupUI로 변경
MutableList에서 List로 변경
두 변수를 private 선언하고, get 함수를 만들어 줌.
onCreate의 테이블 생성 sql 부분을 따로 함수로 분리.
어댑터들의 클릭 리스너를 메인 액티비티에서 받게끔 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어려웠던 점